Skip to content

Migrate DisplayViewHolderFactory to compose #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2025
Merged

Migrate DisplayViewHolderFactory to compose #2876

merged 2 commits into from
Nov 6, 2025

Conversation

@LZRS
Copy link
Collaborator

@LZRS LZRS commented Sep 4, 2025

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2857

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@LZRS LZRS marked this pull request as ready for review September 4, 2025 15:55
@LZRS LZRS requested a review from a team as a code owner September 4, 2025 15:55
@LZRS LZRS requested a review from jingtang10 September 4, 2025 15:55
@LZRS LZRS force-pushed the sdc-compose-display-view branch from ec95f09 to e49adf5 Compare September 16, 2025 01:05
@LZRS LZRS force-pushed the sdc-compose-display-view branch from e49adf5 to 23d89a3 Compare October 15, 2025 23:49
jingtang10
jingtang10 approved these changes Nov 4, 2025
View reviewed changes
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls just add a screenshot. last commit looks fine (assuming the previous quantity pr gets merged)

@github-project-automation github-project-automation bot moved this from New to PR under Review in Android FHIR SDK Nov 4, 2025
@LZRS LZRS force-pushed the sdc-compose-display-view branch from 23d89a3 to b5e9635 Compare November 4, 2025 22:47
@LZRS
Copy link
Collaborator Author

LZRS commented Nov 5, 2025 •
edited
Loading

display Questionnaire items with different custom styling

Before Migration

Screen_recording_20251105_144654.mp4

After Migration

Screen_recording_20251105_144227.mp4

@jingtang10 jingtang10 enabled auto-merge (squash) November 6, 2025 10:37
@jingtang10 jingtang10 merged commit 209c682 into google:master Nov 6, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from PR under Review to Complete in Android FHIR SDK Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingtang10 jingtang10 jingtang10 approved these changes

Assignees

No one assigned

Labels

kokoro:force-run

Projects

Android FHIR SDK
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate DisplayViewHolderFactory to compose

2 participants

@LZRS @jingtang10